Refactor: 웹소켓 서비스 코드 분리 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youthhing
reviewed
Aug 14, 2024
src/main/java/org/cotato/csquiz/domain/education/service/QuizSolveService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/education/service/QuizSolveService.java
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/education/service/SocketService.java
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/education/service/QuizService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/education/service/SocketService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/education/service/SocketService.java
Outdated
Show resolved
Hide resolved
Youthhing
reviewed
Aug 14, 2024
src/main/java/org/cotato/csquiz/domain/education/service/SocketService.java
Outdated
Show resolved
Hide resolved
- 사용하지 않는 코드 삭제 - 퀴즈 상태 전체 끄기 메소드 위치 이동 및 쿼리 최적화 - Transactional 삭제
gikhoon
force-pushed
the
refactor/#MF-16-separate-websocket-service
branch
from
9f30ad3
to
e276a64
Compare
Youthhing
approved these changes
Aug 14, 2024
Youthhing
added a commit
that referenced
this pull request
Aug 15, 2024
* Feature: 프로젝트 관련 테이블 생성 (#93) * feat: 프로젝트 관련 Entity 구현 * refactor: 프로젝트 관련 엔티티 수정 - 프로젝트 서비스 url 칼럼 추가 - unique 제약 조건 삭제 * refactor: builder에 project_url 추가 * style: 코드 스타일 통일 * Refactor: 웹소켓 서비스 코드 분리 (#94) * refactor: 웹소켓 핸드쉐이크 파일 위치 변경 * refactor: 코드 리펙토링 - 사용하지 않는 코드 삭제 - 퀴즈 상태 전체 끄기 메소드 위치 이동 및 쿼리 최적화 - Transactional 삭제 * refactor: 소켓 토큰 발급 시 AuthenticationPrincipal 활용 * refactor: 교육 시작 시 캐시에 정답 저장 메서드 위치 변경 * refactor: 교육 열기 메소드 명 변경 * refactor: 사용하지 않는 메소드, 필드 제거 --------- Co-authored-by: youth <boysoeng@naver.com> * Feature: 출석 정보 반환 필드 세션 ID 추가 (#97) * feat: 출결 반환 필드 세션 PK 추가 * refactor: online, offline 필드명 변경 --------- Co-authored-by: Yun Ha Park <127095481+yunhacandy@users.noreply.github.com> Co-authored-by: GiHun Nam <52378919+gikhoon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
이슈링크(url):
✅ 작업 내용
🗣 ️리뷰 요구 사항
1차적으로 완료했는데 리펙토링 더 필요한 부분 찾고 있습니다